The identity box is improperly styled with highlighting disabled. Topic is solved

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
RexyDallas

The identity box is improperly styled with highlighting disabled.

Unread post by RexyDallas » 2018-03-19, 23:47

The identity box is improperly styled when highlighting is disabled. It shows white on the top and bottom. This is because it leaves room for the background of the urlbar to show up. However, when highlighting is disabled, it should use different styling, as this looks awkward when the highlighting is absent.

How it currently looks:
Image

How I would expect it to look:
Image
Last edited by RexyDallas on 2018-03-20, 00:21, edited 5 times in total.

RexyDallas

Re: The identity box is improperly styled with highlighting disabled.

Unread post by RexyDallas » 2018-03-20, 15:58

Just as a note, this is how I styled it:
Image

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35479
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: The identity box is improperly styled with highlighting disabled.

Unread post by Moonchild » 2018-03-20, 17:43

The styling is exactly as-designed.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

RexyDallas

Re: The identity box is improperly styled with highlighting disabled.

Unread post by RexyDallas » 2018-03-21, 05:47

Moonchild wrote:The styling is exactly as-designed.
So you intentionally designed it to be weird-looking when highlighting is disabled?
Last edited by RexyDallas on 2018-03-21, 05:52, edited 5 times in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35479
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: The identity box is improperly styled with highlighting disabled.

Unread post by Moonchild » 2018-03-21, 08:45

It's not weird looking. It's just not "flat".
It certainly isn't a bug.

If a majority of people feel this styling should be changed, then I'll be more than happy to do so.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

RexyDallas

Re: The identity box is improperly styled with highlighting disabled.

Unread post by RexyDallas » 2018-03-22, 00:15

Moonchild wrote:It's not weird looking. It's just not "flat".
It certainly isn't a bug.

If a majority of people feel this styling should be changed, then I'll be more than happy to do so.
Ok. It doesn't matter much, anyway.

Locked