Held right mouse button occasionally repeats input since 27.4.0

[Dariush]

I don't know how exactly to describe this, but basically if the RMB is held when a new tab is selected or a new page is opened, occasionally the click or other action will repeat. The easiest way to check is with addon Context Search X - if you select some text, without releasing LMB open the context menu and click RMB to search in the same page, on 27.4.0+ a new context menu will immediately open on the spot where the context menu item was clicked, whereas on 27.3.0 and earlier nothing will happen. More importantly (and rarely), from around the time I upgraded to this version FireGestures started occasionally repeating gestures, so when I close a tab, a second one might be invisibly closed along with it. As you might imagine, this is a bit catastrophic.
I am on Windows 7 x64.

[Moonchild]

hmm.. I think this might be a problem with the implementation of the "auxclick" event.
I played around with this a little and it seems to also double-up opening tabs when middle-clicking a link, or double-close when middle-clicking a tab.

[JustOff]

hmm.. I think this might be a problem with the implementation of the "auxclick" event.

Yes, this is the most likely reason. It requires the author to correct the extension, like it was done here and there.

[Moonchild]

I've backed this out for now. I'll be making a new unstable build later today -- could you give that a try and see if the problem persists with this backed out?

[Moonchild]

hmm.. I think this might be a problem with the implementation of the "auxclick" event.

Yes, this is the most likely reason. It requires the author to correct the extension, like it was done here and there.

Unfortunately it also affects our own front-end, without extensions. This means that the patch to implement this was incomplete. See Issue #1304.

[JustOff]

Hmm... Could the OP author or someone else confirm this issue on a clean profile without extensions?

[Moonchild]

I've backed this out for now. I'll be making a new unstable build later today -- could you give that a try and see if the problem persists with this backed out?

Never mind this. Seems this was not the reason for the tab behavior. I'll re-apply it to trunk/release, and make the new bug about the FE issue only.

[Dariush]

Sorry if this sounds dumb, but wouldn't it be possible to determine the cause of this behavior by going down the list of relevant-sounding changes between 27.3.0 and 27.4.0 (or even the two nightlies where this was broken), undoing them and checking undoing which one helps? The Context Search X issue can be reproduced 100% of the time, so testing should not be a problem.

By the way, in Firefox this bug was introduced somewhere between 52.3.0 and 53.0.0b1.

[JustOff]

The Context Search X issue can be reproduced 100% of the time.

Btw, I can't reproduce it based on your instructions from the first post.

[Dariush]

Odd. I rechecked and it definitely behaves like that on a fresh profile. Here's what it looks like:

LMB is held for the whole GIF. I make two RMB clicks - once to open the menu, once to select 'Wikipedia'. After I make the second click, the new context menu immediately opens there (which shouldn't happen, and didn't happen on earlier versions).

[JustOff]

Here's what it looks like

Thanks, now I see. This issue should be fixed by the author of "Context Search X" like I said above, but I'll take a look inside the extension code in a spare time.

[Dariush]

Thanks, now I see. This issue should be fixed by the author of "Context Search X" like I said above, but I'll take a look inside the extension code in a spare time.

Looks like you're right - Firefox added auxclick in 53.0, which matches with my observations. However, I don't quite understand, how could simply adding support for a new event (that obviously could not have been used in the older version of the addon) cause this behavior?

[JustOff]

I don't quite understand, how could adding support for a new event (that obviously could not have been used in the older version of the addon) cause this behavior?

This new event also opens a context menu, but since the add-on don't know about this event - it does not suppress it, as it does on regular right click.

[Dariush]

Ah, makes sense. However, that doesn't sound applicable to the main problem of FireGestures gestures being repeated on another tab (which happens very rarely and thus cannot be reliably reproduced), so it looks like I was mistaken in thinking that the two bugs are related. Any ideas what might be causing that?

[fillerup]

i have a situation which might be related to this. having the Mouse Gestures Suites addon installed along with Imagus's "right click to zoom image" option enabled, causes the context menu to open whenever i attempt to zoom a hovered image with right click. The feature functions properly when MGS is disabled/uninstalled, and the behavior doesn't happen on FF 47 nor FF 54 when both addons are installed

[fillerup]

did some more testing and it turns out the problem i mentioned in my post above only occurs on Linux and not Windows (7)