webrtc bug

The place to report Pale Moon specific bugs on the Windows operating system.
Post Reply
User avatar
Fedor2
Astronaut
Astronaut
Posts: 692
Joined: 2016-04-11, 01:26

webrtc bug

Post by Fedor2 » 2020-05-20, 05:27

You can check it on the Basilisk only because webrtc disabled in Palemoon.
file - media\webrtc\signaling\src\media-conduit\VideoConduit.cpp

~WebrtcVideoConduit() has SyncTo(nullptr); which is coded as

Code: Select all

    mPtrViEBase->DisconnectAudioChannel(mChannel);
    mPtrViEBase->SetVoiceEngine(nullptr);
meanwhile DeleteStreams() has

Code: Select all

mPtrViEBase = nullptr;
and executed earlier ~WebrtcVideoConduit(), so you get excpetion 0xc0000005 in result
I moved SyncTo(nullptr) to DeleteStreams() before mPtrViEBase = nullptr and bug seems gone, what do you think o this.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26661
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: webrtc bug

Post by Moonchild » 2020-05-20, 10:39

I think this would be a good thing to make a GitHub issue for, then file a PR for ;)
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
Fedor2
Astronaut
Astronaut
Posts: 692
Joined: 2016-04-11, 01:26

Re: webrtc bug

Post by Fedor2 » 2020-05-20, 16:30

Done - issue #1558

Post Reply