Question about Mute Tabs controls Topic is solved

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Question about Mute Tabs controls

Unread post by loxodont » 2019-01-16, 13:53

First, my THX for the 28.3.0 release to all contributors!
No issues seen so far.
Not sure if this is a bug. The "Mute Tabs" function shows in the Context Menu - and works, but doesn't show as an icon in the Tab itself (like in Basilisk). Is this by intention? Maybe I (mis)configured something in TMP or elsewhere...
Inspired by the release notes I looked up in about:config and browser.tabs.showAudioPlayingIcon is set to "true", so I guess they should be displayed(?).
- I'm on Win7-x32

User avatar
Nigaikaze
Board Warrior
Board Warrior
Posts: 1322
Joined: 2014-02-02, 22:15
Location: Chicagoland

Re: Question about Mute Tabs controls

Unread post by Nigaikaze » 2019-01-16, 13:59

It's there for me. Are you using a theme? If so, that might need to be updated to account for the new icon. Or perhaps a tab-related extension is interfering?
Nichi nichi kore ko jitsu = Every day is a good day.

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Question about Mute Tabs controls

Unread post by loxodont » 2019-01-16, 14:23

thx for reply.
Just found out it seemed to be caused by some setting in Tab Mix Plus - don't know which yet. I disabled TMP completely and the speaker icons show on the tabs. :)

User avatar
JustOff
Banned user
Banned user
Posts: 2083
Joined: 2015-09-03, 19:47
Location: UA

Re: Question about Mute Tabs controls

Unread post by JustOff » 2019-01-16, 19:42

loxodont wrote:Just found out it seemed to be caused by some setting in Tab Mix Plus - don't know which yet.
I reported this issue to the TMP developer.

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Question about Mute Tabs controls

Unread post by loxodont » 2019-01-16, 20:12

JustOff wrote: I reported this issue to the TMP developer.
I didn't find any setting and gave up with checking the options in TMP 0.5.5.0 ... Just seen it on TMP issues, THX

User avatar
badnick
Astronaut
Astronaut
Posts: 670
Joined: 2017-03-23, 19:56

Re: Question about Mute Tabs controls

Unread post by badnick » 2019-01-16, 20:16

Confirmed! The icon is not show in the Tab .
Windows 10 pro /64 (version 1809)
PM last/64

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35402
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Question about Mute Tabs controls

Unread post by Moonchild » 2019-01-17, 02:33

badnick wrote:Confirmed! The icon is not show in the Tab .
Not very helpful without also letting people know if you're using TMP or not, etc. etc.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Kinpouge

Re: Question about Mute Tabs controls

Unread post by Kinpouge » 2019-01-17, 10:00

I confirm that the "Mute tab" icon is not shown if Tab Mix Plus is installed.
In Basilisk, though, the icon IS shown, whether TMP is installed or not.

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Question about Mute Tabs controls

Unread post by loxodont » 2019-01-17, 10:41

thx Kinpouge :) , JustOff from Pale Moon team already reported this to the developer of TabMixPlus and hopefully this will be fixed in a next TMP release.

User avatar
loxodont
Astronaut
Astronaut
Posts: 725
Joined: 2014-07-26, 23:03
Location: Mare Serenitatis

Re: Question about Mute Tabs controls

Unread post by loxodont » 2019-01-17, 11:01

* - related to the badnick post which just disappeared
So there's probably another add-on hiding the tab audio control with "All tab helper" (which i don't know)? - seems solved
I can exclude "Lull the tabs" causing this, because the icons were displayed when i only turned off TMP.

*Besides, I would suggest to move this post to the Extensions area, as it seems to be an add-on issue, not a bug.*
Last edited by loxodont on 2019-01-17, 11:14, edited 1 time in total.

User avatar
badnick
Astronaut
Astronaut
Posts: 670
Joined: 2017-03-23, 19:56

Re: Question about Mute Tabs controls

Unread post by badnick » 2019-01-17, 11:05

Moonchild wrote:Not very helpful without also letting people know if you're using TMP or not, etc. etc.
Sorry for my mystake, I checked again, it works , the icon is present but when I checked first time I did it only on the active tab (where the sound plays) and because I use the default theme the color of the active tab is almost the same with the icon color and the icon is viirtually invisible.
Windows 10 pro /64 (version 1809)
PM last/64

User avatar
FranklinDM
Add-ons Team
Add-ons Team
Posts: 570
Joined: 2017-01-14, 02:40
Location: Philippines
Contact:

Re: Question about Mute Tabs controls

Unread post by FranklinDM » 2019-01-18, 09:23

I've done a quick look on the extension and TMP seems to hide the audio indicator when it detects that the browser version is < 42.0 based on line 1881 of chrome/content/tab/tab.js.

Code: Select all

    /* tab-icon-sound added by Bug 486262, Firefox 42+ */
    if (!Tabmix.isVersion(420)) {
      this.insertRule('.tab-icon-sound {display: none;}');
    }

garoto
Moongazer
Moongazer
Posts: 9
Joined: 2016-02-12, 19:07

Re: Question about Mute Tabs controls

Unread post by garoto » 2019-01-22, 14:12

Code: Select all

    /* tab-icon-sound added by Bug 486262, Firefox 42+ */
    if (!Tabmix.isVersion(420)) {
      this.insertRule('.tab-icon-sound {display: none;}');
    }
Commenting this block makes the icon appear. Thanks for that!

User avatar
inrobert
Hobby Astronomer
Hobby Astronomer
Posts: 24
Joined: 2018-04-03, 19:44

Re: Question about Mute Tabs controls

Unread post by inrobert » 2019-02-07, 19:31

Is there any option available to remove "Mute tab" from tab context menu? It appears on the first place in the context menu since 28.3 version - not very good if you are used to different layout.
I'm using Pale Moon 28.3.1 (64-bit) and TabMixPlus 0.5.6.0.

User avatar
jars_
Lunatic
Lunatic
Posts: 397
Joined: 2016-12-27, 00:12

Re: Question about Mute Tabs controls

Unread post by jars_ » 2019-02-07, 19:37

remove "Mute tab" from tab context menu? It appears on the first place in the context menu since 28.3 version
userChrome.css:

Code: Select all

#context_toggleMuteTab {display: none !important}

User avatar
inrobert
Hobby Astronomer
Hobby Astronomer
Posts: 24
Joined: 2018-04-03, 19:44

Re: Question about Mute Tabs controls

Unread post by inrobert » 2019-02-07, 22:16

Thank you, it worked, however it leaves the divider (separator) on top of the menu.
I guess they forgot to add this option in TabMixPlus new version (released today v0.5.6.0) – you can disable every other context menu option there.

User avatar
jars_
Lunatic
Lunatic
Posts: 397
Joined: 2016-12-27, 00:12

Re: Question about Mute Tabs controls

Unread post by jars_ » 2019-02-07, 23:01

We can only remove All separators in TabMenu:

Code: Select all

#tabContextMenu > menuseparator { display: none !important; }
how to remove only first one, I do not know. they have neither classes nor id :eh:

Me generally removed separators from everywhere:

Code: Select all

menupopup > menuseparator { display: none !important; }

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: Question about Mute Tabs controls

Unread post by coffeebreak » 2019-02-08, 10:03

inrobert wrote:it leaves the divider (separator) on top of the menu.
jars_ wrote:how to remove only first one... they have neither classes nor id

See: How do I remove the separators in the right-click tab context menu?


To remove just the first separator:

Code: Select all

#context_toggleMuteTab+menuseparator {display: none !important;}

User avatar
jars_
Lunatic
Lunatic
Posts: 397
Joined: 2016-12-27, 00:12

Re: Question about Mute Tabs controls

Unread post by jars_ » 2019-02-08, 16:16

O, thanks coffeebreak useful "plus", did not know about this.

User avatar
inrobert
Hobby Astronomer
Hobby Astronomer
Posts: 24
Joined: 2018-04-03, 19:44

Re: Question about Mute Tabs controls

Unread post by inrobert » 2019-02-09, 00:35

Works well, thanks.

Locked