mozglue crash related
mozglue crash related
Mozglue is replacing regular memory functions like malloc and free with its own functions. And in the code someone likes do free the NULL pointer; this handled normally by regular free, but eventually causes the mozglue crash, what is the point of that free nothing code?
Re: mozglue crash related
mozglue contains jemalloc, our memory allocator lib. It also has plenty of checks and safeguards.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
It is wonderfully how heavy the mozglue code are executing, the most executing code at all, 100 times per second malloc and free for sure, can only roughly determine the place of the crash. Free the null pointer was not the cause. There are more functions variants _aligned_free and _aligned_malloc they. On the off-chance i had replaced them with regular ones and crashes have gone.
Re: mozglue crash related
I instead replaced mozjemalloc/jemalloc.c with newer version in firefox 54, and I don't encounter any crash(except OOM)Fedor2 wrote:It is wonderfully how heavy the mozglue code are executing, the most executing code at all, 100 times per second malloc and free for sure, can only roughly determine the place of the crash. Free the null pointer was not the cause. There are more functions variants _aligned_free and _aligned_malloc they. On the off-chance i had replaced them with regular ones and crashes have gone.
Re: mozglue crash related
Perhaps you did not understand what I said: it has our memory allocator code. That *is* called 100s of times per second if you visit websites per normal.Fedor2 wrote:It is wonderfully how heavy the mozglue code are executing,
If with "regular ones" you mean using the system allocator calls instead, you're probably creating leaks, especially if your arena/recycling and surrounding memory management code is still jemalloc.roytam1 wrote:On the off-chance i had replaced them with regular ones and crashes have gone.
Interesting, I'll have to check and see what the diff is. that code doesn't get touched a lot.roytam1 wrote:I instead replaced mozjemalloc/jemalloc.c with newer version in firefox 54, and I don't encounter any crash(except OOM)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
i meant regular malloc and free of the mozglue of courese but without aligned prefixyou mean using the system allocator calls instead
Well i shall look to it, c means that it still developed by old programmer, because i consider that today's newer is usually much worse.I instead replaced mozjemalloc/jemalloc.c with newer version in firefox 54
Last edited by Fedor2 on 2018-03-10, 15:02, edited 1 time in total.
Re: mozglue crash related
well if you're replacing aligned allocations with unaligned ones, then you are most definitely creating microleaks with each alloc/dealloc and fragmenting your memory in an unrecoverable way.
Also, "c" means it's written in c and not c++. Related but different languages. It has nothing to do with "old" or "new" developers or how "modern" the code is.
Also, "c" means it's written in c and not c++. Related but different languages. It has nothing to do with "old" or "new" developers or how "modern" the code is.
Last edited by Moonchild on 2018-03-10, 15:43, edited 1 time in total.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
Well i shall do some test, but does it not fixed in the mozglue? Also for linux there aligned version is disabled manually.most definitely creating microleaks with each alloc/dealloc and fragmenting
Last edited by Fedor2 on 2018-03-10, 18:00, edited 1 time in total.
Re: mozglue crash related
No idea what you're trying to say, sorry.
In the meantime I've made some minor adjustments/improvements to jemalloc -- one thing that was incorrect was the smallest alloc size on Windows, set to "1" instead of the normally smallest unit based on architecture. I'm pushing out a new unstable with these changes. Testing appreciated.
In the meantime I've made some minor adjustments/improvements to jemalloc -- one thing that was incorrect was the smallest alloc size on Windows, set to "1" instead of the normally smallest unit based on architecture. I'm pushing out a new unstable with these changes. Testing appreciated.
Last edited by Moonchild on 2018-03-10, 18:46, edited 1 time in total.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
I have compiled with your new jemalloc and it runs good, however with HAVE_ALIGNED_MALLOC still crashes mozglue. So i disabled aligned again. msvcrt's aligned maloc and free do not crash though. What is your guess?
Re: mozglue crash related
um... HAVE_ALIGNED_MALLOC is not something that is used in Pale Moon (only in UXP).
So you're going to have to tell me exactly what your're doing to which tree and provide exact crash details (call stack)
So you're going to have to tell me exactly what your're doing to which tree and provide exact crash details (call stack)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
Sorry yes, i do bad, i interbreed palemoon code with newer firefox, i added mozavcodec and mozavutil code
you are not to support this, if only you have some guess.
details
you are not to support this, if only you have some guess.
details
- Attachments
-
- callstack.txt
- (113.11 KiB) Downloaded 17 times
Re: mozglue crash related
Sorry I won't waste my time trying to troubleshoot this. Fine if you want to tinker with your build and trying to hybridize, but you are on your own.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: mozglue crash related
You don't even release modified source codes in github and/or release page.Fedor2 wrote:Sorry yes, i do bad, i interbreed palemoon code with newer firefox, i added mozavcodec and mozavutil code
you are not to support this, if only you have some guess.
details
Re: mozglue crash related
He doesn't have to until/unless he distributes something in binary form.
Re: mozglue crash related
I try keeping updated patches, eventually i shall update.You don't even release modified source codes in github