2 Pane Bookmarks does not work with 27.1.0

[1210_bex]

I run Windows 7 Pro (64 bit) on my desktop and laptop.

2 Pane Bookmarks (Ver. 0.6.2013040601.1.1 signed) does not work with PM 27.1.0 (x86). It works fine with PM 27.0.3 (x86). There are two later versions of 2 Pane Bookmarks, but neither are marked by the author as compatible, and PM will not allow either to be installed to test.

Has anyone else run into this problem, and if so, is there a solution or a workaround? This is a great addon. I have used it for many years with PM.


Harry

[fillerup]

install this

https://addons.palemoon.org/extensions/ ... ster-tool/

then remove your addon and try installing through the above

[GMforker]

2 Pane Bookmarks (Ver. 0.6.2013040601.1.1 signed) does not work with PM 27.1.0 (x86). It works fine with PM 27.0.3 (x86). There are two later versions of 2 Pane Bookmarks, but neither are marked by the author as compatible, and PM will not allow either to be installed to test.
Has anyone else run into this problem, and if so, is there a solution or a workaround? This is a great addon. I have used it for many years with PM.

See viewtopic.php?f=16&t=14743&p=105941#p105941

The file: "content\bookmarks2pane\bookmarksPanelOverlay.js" - you must overwrite those lines (4x):

1. (line 269)
From:

Code: Select all

let (source = PlacesTreeView.prototype._buildVisibleSection.toSource()) {

To:

Code: Select all

{
let source = PlacesTreeView.prototype._buildVisibleSection.toSource();

2. (line 312)
From:

Code: Select all

let (method = PlacesTreeView.prototype.itemInserted ? 'itemInserted' : 'nodeInserted' ) {

To:

Code: Select all

{
let method = PlacesTreeView.prototype.itemInserted ? 'itemInserted' : 'nodeInserted';

3. (line 326)
From:

Code: Select all

let (method = PlacesTreeView.prototype.itemRemoved ? 'itemRemoved' : 'nodeRemoved' ) {

To:

Code: Select all

{
let method = PlacesTreeView.prototype.itemRemoved ? 'itemRemoved' : 'nodeRemoved';

4. (line 342)
From:

Code: Select all

let (method = PlacesTreeView.prototype.itemMoved ? 'itemMoved' : 'nodeMoved' ) {

To:

Code: Select all

{
let method = PlacesTreeView.prototype.itemMoved ? 'itemMoved' : 'nodeMoved';

[CraigPD]

See viewtopic.php?f=16&t=14743&p=105941#p105941

The file: "content\bookmarks2pane\bookmarksPanelOverlay.js" - you must overwrite those lines (4x):

1. (line 269)
From:

Code: Select all

let (source = PlacesTreeView.prototype._buildVisibleSection.toSource()) {

To:

Code: Select all

{
let source = PlacesTreeView.prototype._buildVisibleSection.toSource();

Thanks for the practical application, GMforker. Much clearer to us non-developer types than MC's generalized outline.

[1210_bex]

The file: "content\bookmarks2pane\bookmarksPanelOverlay.js" - you must overwrite those lines (4x):

1. (line 269)
From:

Code: Select all

let (source = PlacesTreeView.prototype._buildVisibleSection.toSource()) {

To:

Code: Select all

{
let source = PlacesTreeView.prototype._buildVisibleSection.toSource();

4. (line 342)
From:

Code: Select all

let (method = PlacesTreeView.prototype.itemMoved ? 'itemMoved' : 'nodeMoved' ) {

To:

Code: Select all

{
let method = PlacesTreeView.prototype.itemMoved ? 'itemMoved' : 'nodeMoved';

Where do I find this file and these lines?

The closest I could find was: C:\Users\HMW\AppData\Roaming\Moonchild Productions\Pale Moon\Profiles\su46gq4v.default\extensions\sidebarBookmarksSearch@alice\chrome\content\bookmarksPanelOverlay3.7js. It seems to have been modified 5/29/2015.

There are no lines/words in this .js file that match what you describe.

Harry

[CraigPD]

Harry,
The file / line modifications referenced are located in your profile folder - C:\Users\HMW\AppData\Roaming\Moonchild Productions\Pale Moon\Profiles\su46gq4v.default\extensions\{FD61379B-066A-4afc-89DE-89FB24D907C2}.xpi.

For practice I made the suggested modifications and it tested fine after installing in PM 27.1 (x86) portable. I'm attaching the modified extension (.xpi) file here for your benefit / ease of use, thanks again to GMforker's guidance.

Moderator note: rogue edited extension removed.

[1210_bex]

Harry,
The file / line modifications referenced are located in your profile folder - C:\Users\HMW\AppData\Roaming\Moonchild Productions\Pale Moon\Profiles\su46gq4v.default\extensions\{FD61379B-066A-4afc-89DE-89FB24D907C2}.xpi.

For practice I made the suggested modifications and it tested fine after installing in PM 27.1 (x86) portable. I'm attaching the modified extension (.xpi) file here for your benefit / ease of use, thanks again to GMforker's guidance.

I renamed the file you sent to {FD61379B-066A-4afc-89DE-89FB24D907C2}.xpi, which I assume I was supposed to do.

WORKS PERFECT!

And thanks for creating the file. I could not determine how to open the sub-file "content\bookmarks2pane\bookmarksPanelOverlay.js" and make the changes.


Harry

[Moonchild]

Kindly do post in the correct board next time. If you have add-on compatibility issues, post it in the add-on compatibility board. The one you posted in is for issues with the add-ons website itself, not extensions.

[1210_bex]

Kindly do post in the correct board next time. If you have add-on compatibility issues, post it in the add-on compatibility board. The one you posted in is for issues with the add-ons website itself, not extensions.

Sorry.

Harry

[bjosephs]

Thanks so much for the file. It worked perfectly for me and restored the two pane books to my Pale Moon. I'm a happy camper once again.

[riiis]

2 Pane Bookmarks version 1.0.2016020701, which is the latest version, appears compatible and runs fine in PM 27.4.1. It just doesn't seem to want to install. Note that the problems with the let statements, in prior versions of 2 Pane Bookmarks, appear fully corrected in the current version.

To install the current version of 2 Pane Bookmarks in PM 27, add Pale Moon 27, as a target application to the "2 Pane Bookmarks" install.rdf file. Alternatively, change the Firefox target application code from:

Code: Select all

    <em:targetApplication>
      <!-- Firefox -->
      <RDF:Description em:id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
                       em:minVersion="38.0"
                       em:maxVersion="47.0a1" />
    </em:targetApplication>

To:

Code: Select all

    <em:targetApplication>
      <!-- Firefox -->
      <RDF:Description em:id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
                       em:minVersion="27.0"
                       em:maxVersion="47.0a1" />
    </em:targetApplication>

I tried to use the Moon Tester Tool version 1.0.6, to modify and install 2 Pane Bookmarks version 1.0.2016020701, but MTT failed to do so. Instead, I had to make the change manually. MTT was handy in downloading 2 Pane Bookmarks from AMO, however. MTT now provides a context menu "Save Link As ...", so that "incompatible extensions" like 2 Pane Bookmarks can now be downloaded easily.

2_2_pane_bookmarks-1.0.2016020701.png (74.1 KiB) Viewed 1962 times

[JustOff]

2 Pane Bookmarks version 1.0.2016020701, which is the latest version, appears compatible and runs fine in PM 27.4.1. [...] I tried to use the Moon Tester Tool version 1.0.6, to modify and install 2 Pane Bookmarks version 1.0.2016020701, but MTT failed to do so.

This issue was resolved in Moon Tester Tool 1.1.0.

[riiis]

This issue was resolved in Moon Tester Tool 1.1.0.

Thanks for fixing so quickly.

I noticed MTT provides support for only two languages. By tweaking MTT's option.xul file, to use Pale Moon's own locale files and language packs, you should be able to provide support for all Pale Moon locales. Following is my revised coding for the options.xul file.

Code: Select all

<?xml version="1.0" ?>

<!DOCTYPE window [
    <!ENTITY % browserDTD SYSTEM "chrome://browser/locale/places/places.dtd"> %browserDTD;
<!ENTITY % selectextensionDTD SYSTEM "chrome://mozapps/locale/extensions/extensions.dtd">
%selectextensionDTD;
]>

<vbox xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
	<setting type="control" title="&installAddonFromFile.label;">
    <button label="&cmd.restoreFromFile.label;" oncommand="Services.obs.notifyObservers(window, 'moonttoolEvent', 'Run');"/>
	</setting>
</vbox>

With these changes, here is what MTT options would look like in English:

And, here is what MTT options would look like in German:

[JustOff]

Off-topic:

I noticed MTT provides support for only two languages. By tweaking MTT's option.xul file, to use Pale Moon's own locale files and language packs, you should be able to provide support for all Pale Moon locales.

Thanks, but it's a kind of offtopic here, let's continue the MTT discussion there.