"Find in page" combo-box memorization Topic is solved

[Robby]

Find in page combo-box (Ctrl-F)

One thing I would find very useful would be to have a combo-box instead of an edit control for the "Find in page"
It could remember the last, let say 20 or 50 last search request.
In Windows, CBS_DROPDOWN style with no CBS_SORT could be used to permit a "last in" "top of list" arrangement.
Here is some very bad, untested, and quickly written code that show what I mean...

Regards,
Robby

MaxComboboxListCount = 50;

CharCount == SendMessage(hComboBox, WM_GETTEXTLENGTH, 0, 0); //Get the text length of the combo-box-edit control, excluding the zero terminator
if CharCount //If it is not empty
{
pBuffer == HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, CharCount + 2); //Allocate a buffer to store it
SendMessage(hComboBox, WM_GETTEXT, CharCount + 1, pBuffer); //Copy the text from the combo-box edit control to the buffer, including the zero terminator

while //Eliminate all duplicates, normally, no more than one should be found in the combo-box list.
{
Itemfound == SendMessage(hComboBox, CB_FINDSTRINGEXACT, -1, pBuffer); //Search whole list for duplicate
IF Itemfound == CB_ERR break; //Exit loop when no found...
SendMessage(hComboBox, CB_DELETESTRING, Itemfound, 0); //Delete duplicate
}

//Check if the maximum, item count is reached..
while SendMessage(hComboBox, CB_GETCOUNT, 0, 0) > MaxComboboxListCount
{
SendMessage(hComboBox, CB_DELETESTRING, MaxComboboxListCount, 0); //Keep items count reasonable
}

SendMessage(hComboBox, CB_INSERTSTRING, 0, pBuffer); //Insert the text from the combo-box-edit control first in the combo-box list
HeapFree(GetProcessHeap(), 0, pBuffer); //Free memory
}

[moonbat]

This is why the browser is fully extensible unlike its shitty competition. You can write an extension that overlays the findbar to display a combo box instead of a textbox and override the existing logic all using XUL and Javascript; there is no need to delve into C++ like that.
Further bonus, this feature becomes available only to those who want it and those who are happy with the existing behavior don't have their browser bloated with unnecessary additional code for a feature that is of no use to them.

Take a look at this extension, examine the code and refer to the XUL Tutorial to get started.

[Robby]

This looks really, really interesting...
Thanks

[moonbat]

Also see the XUL School Tutorial, it is a little more newbie friendly and takes you through setting up a dev environment as well.

[Moonchild]

Closing this as a core browser suggestion entry -- extension's the way to go.