Bookmark All INCLUDING Pinned Tabs?

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
Locked
DoctorM
Fanatic
Fanatic
Posts: 146
Joined: 2014-07-31, 18:19
Location: USA

Bookmark All INCLUDING Pinned Tabs?

Unread post by DoctorM » 2017-11-02, 22:31

I've noticed that "Bookmark All" only appears if you have two or more unpinned tabs and pinned tabs aren't bookmarked.

It would be nice to have an option to include pinned tabs as well. I occasionally find myself with lots of pages pinned and I want to bookmark them all in case of a crash. Right now the only solution is to manually unpin all first, bookmark all and then re-pin.
Top
GMforker

Re: Bookmark All INCLUDING Pinned Tabs?

Unread post by GMforker » 2017-11-03, 05:57

If anyone has time to do it, the relevant code is here:

Omitting pinned tabs from tabs (URLs) list:
browser/base/content/browser-places.js#L379
Omitting pinned tabs (for the context menu - "Bookmark All Tabs…"):
browser/base/content/browser.js#L6826
Count of tabs (URLs) list >= 2:
browser/base/content/browser-places.js#L411
Top
Locked

Return to “Browser Development”