No malicious recursive deletion of invalid addons

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
cyisfor

No malicious recursive deletion of invalid addons

Unread post by cyisfor » 2017-08-06, 18:43

When I link my development addon to the extension directory, and accidentally use the wrong ID for a filename, it'd be a really nice feature if Palemoon just deleted the link, instead of following the link, deleting all files recursively including the .git directory so that all my work has been lost, then deleting the link. I'd call it a bug, but there's no way that wasn't intentional. Just more malicious code inherited from Firefox, I think.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: No malicious recursive deletion of invalid addons

Unread post by Moonchild » 2017-08-06, 23:15

There is no way for a simple file deletion call to know if something is a filesystem link or an actual folder. Removing the folder for the extension recursively if in unpacked state, when removing the extension, is indeed by design.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked