Suggestion: Downloads tab icon!

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
petrus

Suggestion: Downloads tab icon!

Unread post by petrus » 2017-06-17, 15:44

Why? Because the downloads tab is so important, that it should stand out!

Hence i suggest using this icon for it:
resource:///chrome/browser/skin/classic/browser/places/downloads.png
Image

Like if you do the following, but by default, out of the box:

Code: Select all

#tabbrowser-tabs .tabbrowser-tab[label^="Downloads"] .tab-icon-image { list-style-image: url("resource:///chrome/browser/skin/classic/browser/places/downloads.png") !important;}

User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Re: Suggestion: Downloads tab icon!

Unread post by adesh » 2017-06-17, 16:24

I second that suggestion. Empy file icon for Downloads doesn't say much. Maybe we'll see this in 27.4?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35627
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Suggestion: Downloads tab icon!

Unread post by Moonchild » 2017-06-17, 22:41

And then you will be replacing the icon of any tab that has a page title "Downloads" with the icon...
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

petrus

Re: Suggestion: Downloads tab icon!

Unread post by petrus » 2017-06-17, 23:48

Feel free to tell me the correct selector then, i wouldn't mind at all!

Like: about:robots

That tab has an icon!

petrus

Re: Suggestion: Downloads tab icon!

Unread post by petrus » 2017-06-19, 17:53

I tried messing with url= but i just couldn't figure it out, so enlighten me Mr. Moon! I do wanna do this the right way.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35627
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Suggestion: Downloads tab icon!

Unread post by Moonchild » 2017-06-19, 21:30

You can offer a patch following the recommendation and user notes of the XUL window element:

https://developer.mozilla.org/en-US/doc ... User_Notes

The file to patch would be:
/browser/components/downloads/content/contentAreaDownloadsView.xul
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

petrus

Re: Suggestion: Downloads tab icon!

Unread post by petrus » 2017-06-20, 12:53

Good news, Lootyhoof may look into this: "The change to the source is trivial, I may look into it."

Meanwhile, any idea how to "fuse" @-moz-document url(about:downloads) &
list-style-image: url("chrome://browser/skin/places/downloads.png"), or i guess in this case it's not list-style-image?

Can't figure it out, I'm going nuts over this!

petrus

Re: Suggestion: Downloads tab icon!

Unread post by petrus » 2017-06-21, 16:08

Just fyi, the Download Manager Tweak extension adds a nice tab icon, highly recommend, and not just for the icon:
Image

Locked