Open "Add-ons Manager" and "Permissions Manager" in new window

[xtal256]

I like the recent addition of the "Permissions" menu item, which opens the Permissions Manager in a new tab. However, I prefer these type of config/manager things to open in a separate window/dialog.

How difficult would it be to make the "Add-ons Manager" and "Permissions Manager" open in new windows instead of tabs? Ideally there would be a preference to control it, as I imagine not everyone would want them in a new window.

I currently am using an add-on which is a modification of the Classicish Add-on Manager, utilizing it's ability to open the manager in a new window. I am thinking of modifying it further to also handle the Permissions Manager. However, if I can have this behaviour as part of the browser itself, it would be much nicer (my understanding is that the add-on uses some hacks to allow it to work).

[_yuyu_]

More In Content UI + can make it.

[Moonchild]

More In Content UI + can make it.

They want less in-content, not more...

[_yuyu_]

They want less in-content, not more...

Hard to beleive but it can do less too))

[Moonraker]

Javascript control in the permissions window would be nice.Saves using an extension or digging around pale moon commander.
Just a friendly suggestion.

[xtal256]

Javascript control in the permissions window would be nice.Saves using an extension or digging around pale moon commander.
Just a friendly suggestion.

I think that's a bit off-topic. I suggest you create a new topic for that.

They want less in-content, not more...

Hard to believe but it can do less too))

I tried that add-on, but it did not allow me to open existing in-content pages as new windows. It seems to be designed specifically for making windows open as tabs and not the other way around.

@Moonchild: How difficult would it be to implement this feature? I could do it myself, but it would take me a long time to familiarise myself with the code-base, so I'd need a lot of help from other Pale Moon developers.

[Moonchild]

The issue with having a windowed and an in-content version of something is that they usually require different code. Keeping both in the browser also means both types of code need to be maintained; implementing it won't be a one-shot deal as it will also need to duplicate any changes in both versions.

Also, for both the add-ons manager and permissions manager, there is the issue that you have larger amounts of data that you can't easily fit into a reasonably-sized dialog box without it being large and having scrollbars -- at that point, you may as well have it in a tab or content window.

[_yuyu_]

I tried that add-on, but it did not allow me to open existing in-content pages as new windows. It seems to be designed specifically for making windows open as tabs and not the other way around.

Yes, you're right, sorry for misleading. Thought it would work two-way.

[xtal256]

The issue with having a windowed and an in-content version of something is that they usually require different code. Keeping both in the browser also means both types of code need to be maintained; implementing it won't be a one-shot deal as it will also need to duplicate any changes in both versions.

Ok, fair enough. I'll try to extend my add-on then.

Also, for both the add-ons manager and permissions manager, there is the issue that you have larger amounts of data that you can't easily fit into a reasonably-sized dialog box without it being large and having scrollbars -- at that point, you may as well have it in a tab or content window.

That's not really a valid argument, as a window can be any size you like, including making it as big as the browser window.
Besides, both those views still require vertical scroll bars even in a tab, assuming you have a large number of add-ons/permissions and your browser window isn't 2000 pixels high

[xtal256]

Just thinking, if you were to have the window include the in-content view in a browser element, wouldn't that eliminate the duplicate code problem? Because most of the code would still be in-content, and there would be just a little bit of boiler-plate to set up the window around it.

This is what Classicish Add-on Manager does, according to this code:

Code: Select all

<window ... id="addonsManagerWrapper" windowtype="AddonManager:Wrapper" ... >
    <browser id="amBrowser" src="about:addons" flex="1" type="content"/>
    ...
</window>

Unless you're talking about something else. I see the add-on duplicates the bindings xml file. I'm not sure why this is, but I was hoping that it would not be necessary if the functionality was part of core browser rather than an add-on.

[LimboSlam]

This add-on does not work for me. And yes, the permissions Manager seems like it would be in a native window, but it's not. I miss those separate windows for certain functions. Such as the add-on Manager and Downloads, which is why I use Aviary Add-ons Manager and Downloads Window. So, maybe this should be converted into an add-on.

[xtal256]

I would prefer this functionality to be part of the browser, since those windows/tabs are actually part of the browser. Add-ons are more for adding functionality or significantly changing existing functionality. Something like this could (ideally) just be another options somewhere that says "Open Add-ons Manager / Permissions Manager in: <new window> | <new tab>".

[xtal256]

I've modified my add-on I mentioned earlier so it also opens the Permissions Manager in a separate window.
If anyone is interested in the code, I have attached it here. If you want to use it, just rename the .zip file to .xpi and install it. I cannot guarantee it will work on your system, but it's pretty simple so I don't see why it wouldn't (I've actually stripped back a lot of the existing "Classicish Add-on Manager" code).

[LimboSlam]

There are some issues with it. Maybe with Australium? I'll have confirm a bit latter today or tomorrow as I got a business trip.

[xtal256]

Looks fine to me on a plain 27.3 install. Perhaps the issue is with your theme.

[Lootyhoof]

There are some issues with it. Maybe with Australium? I'll have confirm a bit latter today or tomorrow as I got a business trip.

If you're referring to about:addons, Australium does some rather...hacky things to do what I'd like with it. It's not really something I can work around for an add-on that does something like this, unfortunately.

With regards to the permissions manager any oddly-placed labels and missing icons will be addressed as I find time to do so, as I want to do some other big changes to that theme anyway.

[LimboSlam]

If you're referring to about:addons, Australium does some rather...hacky things to do what I'd like with it. It's not really something I can work around for an add-on that does something like this, unfortunately.

With regards to the permissions manager any oddly-placed labels and missing icons will be addressed as I find time to do so, as I want to do some other big changes to that theme anyway.

Yes, I was. Thanks.

[LimboSlam]

I have some more questions, and hopefully xtal256 or Lootyhoof can answer them:

1) Does Windowify adapt to certain complete themes, such as Fox 2 The Moon and Moonfox3?
2) Or just adapt to a more native appearance, like the current add-ons manager in Pale Moon?
3) Will it be versatile in which native scheme it takes on, notably Mac and Linux?
4) Is it supposed to resemble and function similar to Classicish Add-on Manager screenshots on AMO?


Thanks again, !