sepllcheck dictionary

[Fedor2]

In Pale Moon 26 there is spellchecker.dictionary.override setting. But in the 27 it was removed, instead there is spellchecker.dictionary but it never do its purpose.

So i found that changing only one string in
editor\composer\nsEditorSpellCheck.cpp
allow use it as that in PM 26.

Code: Select all

***** nsEditorSpellCheck.bak
  nsAutoString preferedDict(Preferences::GetLocalizedString("spellchecker.dictionary"));
  if (dictName.IsEmpty()) {
    dictName.Assign(preferedDict);
***** nsEditorSpellCheck.CPP
  nsAutoString preferedDict(Preferences::GetLocalizedString("spellchecker.dictionary"));
  //MYPAL CODE
  if (!preferedDict.IsEmpty()) {
    dictName.Assign(preferedDict);
*****

And i suggest make this into regular PM code

[Moonchild]

That's not a good solution. spellcheck.dictionary is used only when no other dictionary preferences (page language, element language) take precedence.
This is different with the platform update than what we had before, and we should simply reintroduce the .override as an extra pref to "always use this, regardless" preference. Issue #980
Simple change, patches welcome.

[Fedor2]

Seems i could to add new setting.

And i have done patch

Code: Select all

741a742,747
>   // Get global preferred language from preferences, if set.
>   nsAutoString preferedDict(Preferences::GetLocalizedString("spellchecker.dictionary.override"));
>   if (!preferedDict.IsEmpty()) {
>     dictName.Assign(preferedDict);
>   }
> 
747c753
<   if (!mPreferredLang.IsEmpty()) {
---
>   if (dictName.IsEmpty() && !mPreferredLang.IsEmpty()) {
752c758
<   nsAutoString preferedDict(Preferences::GetLocalizedString("spellchecker.dictionary"));
---
>   preferedDict=Preferences::GetLocalizedString("spellchecker.dictionary");

Is it right?

[Moonchild]

No I'm afraid that won't do.

I'll poke at it myself when I have a free moment.

[Moonchild]

The logic in place was not very logical, so I went in and re-implemented what we had before. This removed the "spellchecker.dictionary" pref since that was just a "holding" pref anyway and could make dictionary choice bleed through to the next site visited - not a good thing.