Location of blocklist in profile folder?

[Moonchild]

Hmm.. I'm not sure if the display actually gets fixed up then (I probably should do it regardless - commas have no reason to be in a version number), but for the version check it should certainly use a proper format.

@hello* : Are you sure you have the latest version of Flash?

[SvenG]

I did a comparison between the blocklist in my profile folder and the default one and the only differences are related to flash, then I renamed the one in my profile folder, so PM uses the default one and.... flash is marked vulnerable.

Did another comparison, the blocklist I have is
http://blocklist.palemoon.org/25.2.1/blocklist.xml
so this could solve the issue for now.

[Moonchild]

The one that came with the browser should be the same though... if it isn't then I'll have to check again what's in the source tree.

My bad, of course it shouldn't be the same, because I changed the version check in 25.3 and the 25.3 embedded blocklist therefore has the extra flash blocking versions in it -- but it SHOULD not trip over the commas in 25.3 so something else is still wrong.

I'm changing the check to be less specific - it should always fix up commas to periods, regardless of plugin used or locale. I think the issue might be that the very strict MIME check doesn't work to determine if it "is flash". And that would be a problem since it wouldn't fix up the version in that case. Maybe dealing with having to oddly install the flash player, like symlinking and the likes as needed on some distros not registering the type as a result...

In any case, I see no harm in correcting binary-embedded version string stupidity in-browser. The browser needs to be able to check the version properly, so it can fix up silly commas in favor of having a broken check -- I'm not entirely sure why Mozilla's patch made it as strict anyway... "Only do this if on Linux AND if the plugin has x-shockwave-flash as a registered MIME type"... while any comma in any plugin version would break the check.

EDIT: The blocklist I just put on the server for 25.3.0 is not the same as the one that comes with the binary (a good thing in this case since the check isn't working properly yet in all cases as you found out)

[SvenG]

EDIT: The blocklist I just put on the server for 25.3.0 is not the same as the one that comes with the binary (a good thing in this case since the check isn't working properly yet in all cases as you found out)

Just tried Thanks.

[ron_1]

Okay, works for me too, but I still have the commas. Is the correct place to put the blockfile in /home/<name>/.moonchild productions/pale moon/xxxxxxxx.default/ ?

[MC, I am using the latest version.]

[Moonchild]

Yes, you will still have the commas, since apparently it was not entirely fixed (Mozilla's fix works for some and not for others). I'm working on fixing that in the browser.

Just using the one served by the blocklist server will do fine, no need to manually juggle the files.