Titlebar text colour based on persona

[Lootyhoof]

Currently, when a persona is used, the titlebar text is black, whether the persona is light or dark; if it's dark, you can't see the text. What I propose is:

Code: Select all

/* Make titlebar text light/dark depending on persona */
#main-window:-moz-lwtheme-brighttext:after{
    color: white !important;
}
#main-window:-moz-lwtheme-darktext:after{
     color: black !important;
}

Or something similar to that if not that. It'd make it much easier to see the titlebar text depending on what persona is used.

[Antonius32]

Interesting thought, but I think the text colour for the Title bar is actually determined by the OS theme. If you have a lightweight theme installed, just activate the Menu bar and you'll find that the Title bar is no longer affected by the lightweight theme, but looks just like the Title bar for other applications. So changing the Title bar text colour based on the lightweight theme that's used would be problematic for people who actively use the Menu bar, who use a lightweight theme that doesn't match their OS theme (bright-text or non bright-text)...

[New Tobin Paradigm]

This is when we are in AppMenu/No menubar mode wjere we draw it.. This would NOT affect the normal system drawn titlebar in menubar mode

[Antonius32]

This is when we are in AppMenu/No menubar mode wjere we draw it.. This would NOT affect the normal system drawn titlebar in menubar mode

I've just tested the code, and you're absolutely right - it does not affect the Title bar when the Menu bar is active. Well, in that case, I think Lootyhoof has a good point here, and I hope the solution he/she proposes will be implemented in a future version of Pale Moon!

By the way, I think that if you change the text colour, you don't need the text shadow anymore. The following code changes the Title bar text colour and removes the text shadow for dark Personas:

Code: Select all

/* Make Title bar text white and remove text shadow for dark Personas */
#main-window:-moz-lwtheme-brighttext:after {
  color: white !important;
  text-shadow: none !important;
}

[Lootyhoof]

You can probably apply the same to -darktext really, as text shadow is only really there for extra clarity on the glassy title bars, which would otherwise not be glassy when a persona is applied.

[Moonchild]

You can probably apply the same to -darktext really, as text shadow is only really there for extra clarity on the glassy title bars, which would otherwise not be glassy when a persona is applied.

Actually, keeping the opposite contrast shadow is a good thing. There are many themes that have e.g. bright text but where the top of the persona is fairly light - without the shadow you would not be able to see the title anymore.

I'll have a look at making the title more adaptive to personae.

[Antonius32]

I think for many dark themes, changing the Title bar text colour to white and hiding the text shadow benefits both legibility and looks:

Pale Moon + dark lightweight theme - Title bar text.png

But I do realise that for themes that are lighter towards the top, doing this could prove problematic...

I'll have a look at making the title more adaptive to personae.

Great, thank you!

[Lootyhoof]

Potentially a more elegant solution to this, come to think of it:

Code: Select all

#main-window:-moz-lwtheme:after {
  color: inherit !important;
  text-shadow: inherit !important;
}

This way, the titlebar text's colour and shadow are both determined by the persona in use.